lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Sep 2021 10:24:18 +0200 From: Horatiu Vultur <horatiu.vultur@...rochip.com> To: Andrew Lunn <andrew@...n.ch> CC: <davem@...emloft.net>, <kuba@...nel.org>, <robh+dt@...nel.org>, <linux@...linux.org.uk>, <f.fainelli@...il.com>, <alexandre.belloni@...tlin.com>, <vladimir.oltean@....com>, <UNGLinuxDriver@...rochip.com>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-phy@...ts.infradead.org>, <linux-pm@...r.kernel.org> Subject: Re: [RFC PATCH net-next 01/12] net: mdio: mscc-miim: Fix the mdio controller The 09/20/2021 13:52, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, Sep 20, 2021 at 11:52:07AM +0200, Horatiu Vultur wrote: > > According to the documentation the second resource is optional. But the > > blamed commit ignores that and if the resource is not there it just > > fails. > > > > This patch reverts that to still allow the second resource to be > > optional because other SoC have the some MDIO controller and doesn't > > need to second resource. > > > > Fixes: 672a1c394950 ("net: mdio: mscc-miim: Make use of the helper function devm_platform_ioremap_resource()") > > Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com> Hi Andrew, > > Hi Moratiu > > The script kiddies might come long and 'fix' this again. Maybe > consider adding devm_platform_ioremap_resource_optional(), following > the pattern of other _optional() API calls. Otherwise add a comment. Initially I think I will go with the comment. Because this patch actually needs to go on net. > > Andrew -- /Horatiu
Powered by blists - more mailing lists