netdev - Re: nt: usb: USB_RTL8153_ECM should not default to y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210921142803.125d4c6d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 21 Sep 2021 14:28:03 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux NetDev <netdev@...r.kernel.org>,
        Hayes Wang <hayeswang@...ltek.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: nt: usb: USB_RTL8153_ECM should not default to y

On Tue, 21 Sep 2021 09:30:34 +0200 Geert Uytterhoeven wrote:
> > The problem is CDCETHER (ECM) tries to be a generic driver that just
> > works for USB standards compliant generic hardware...
> > (similarly the EEM/NCM drivers)
> >
> > There shouldn't be a 'subdriver'  
> 
> If it does not make any sense to disable USB_RTL8153_ECM if CDCETHER
> is enabled, perhaps the option should just be removed?

And when we say "removed" we can just hide it from what's prompted 
to the user (whatever such internal options are called)? I believe 
this way we don't bring back Marek's complaint.