netdev - Re: nt: usb: USB_RTL8153_ECM should not default to y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX1ZjLFjE5oH7usz5mGPKPBy+qvvt4fN=wUw-BHOBiVqA@mail.gmail.com>
Date:   Tue, 21 Sep 2021 09:30:34 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Maciej Żenczykowski <maze@...gle.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux NetDev <netdev@...r.kernel.org>,
        Hayes Wang <hayeswang@...ltek.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: nt: usb: USB_RTL8153_ECM should not default to y

Hi Maciej,

On Mon, Sep 20, 2021 at 10:20 PM Maciej Żenczykowski <maze@...gle.com> wrote:
> On Mon, Sep 20, 2021 at 9:15 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Sat, 18 Sep 2021 12:53:31 +0200 Geert Uytterhoeven wrote:
> > > > Yeah.. more context here:
> > > >
> > > > https://lore.kernel.org/all/7fd014f2-c9a5-e7ec-f1c6-b3e4bb0f6eb6@samsung.com/
> > > >
> > > > default !USB_RTL8152 would be my favorite but that probably doesn't
> > > > compute in kconfig land. Or perhaps bring back the 'y' but more clearly
> > > > mark it as a sub-option of CDCETHER? It's hard to blame people for
> > > > expecting drivers to default to n, we should make it clearer that this
> > > > is more of a "make driver X support variation Y", 'cause now it sounds
> > > > like a completely standalone driver from the Kconfig wording. At least
> > > > to a lay person like myself.
> > >
> > > If it can be a module (tristate), it must be a separate (sub)driver, right?
> >
> > Fair point.
>
> The problem is CDCETHER (ECM) tries to be a generic driver that just
> works for USB standards compliant generic hardware...
> (similarly the EEM/NCM drivers)
>
> There shouldn't be a 'subdriver'

If it does not make any sense to disable USB_RTL8153_ECM if CDCETHER
is enabled, perhaps the option should just be removed?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds