netdev - Re: Race between "Generic PHY" and "bcm53xx" drivers after -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Sep 2021 21:36:43 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <rmk+kernel@...linux.org.uk>
Subject: Re: Race between "Generic PHY" and "bcm53xx" drivers after
 -EPROBE_DEFER

On Mon, Sep 20, 2021 at 11:25:06AM -0700, Florian Fainelli wrote:
> On 9/20/21 11:17 AM, Vladimir Oltean wrote:
> [snip]
> >> All I am saying is that there is not really any need to come up with a
> >> Device Tree-based solution since you can inspect the mdio_device and
> >> find out whether it is an Ethernet PHY or a MDIO device proper, and that
> >> ought to cover all cases that I can think of.
> > 
> > Okay, but where's the problem? I guess we're on the same page, and
> > you're saying that we should not be calling bcma_mdio_mii_register, and
> > assigning the result to bgmac->mii_bus, because that makes us call
> > bcma_phy_connect instead of bgmac_phy_connect_direct. But based on what
> > condition? Simply if bgmac->phyaddr == BGMAC_PHY_NOREGS?
> 
> Yes simply that condition, I really believe it ought to be enough for
> the space these devices are in use.

So the last question is, are the link parameters advertised by the
switch pseudo PHY identical with the link parameters advertised by the
fixed PHY instantiated by bgmac_phy_connect_direct? If they are, is it
intended or merely a coincidence?