netdev - RE: [PATCH] r8152: stop submitting rx for -EPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Sep 2021 16:13:14 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Oliver Neukum <oneukum@...e.com>,
        Jason-ch Chen <jason-ch.chen@...iatek.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "Project_Global_Chrome_Upstream_Group@...iatek.com" 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...gle.com" <hsinyi@...gle.com>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO

Oliver Neukum <oneukum@...e.com>
> Sent: Thursday, September 30, 2021 5:30 PM
[...]
> Hi,
> 
> Hayes proposed a solution. Basically you solve this the way HID or WDM do it
> delaying resubmission. This makes me wonder whether this problem is specific
> to any driver. If it is not, as I would argue, do we have a deficiency
> in our API?

I think the major question is that the driver doesn't know whether
it is necessary to stop submitting bulk transfer or not. There are
two situations with the same error code. One needs to resubmit
the bulk transfer. The other needs to stop the transfer. The original
idea is that the disconnect event would stop submitting transfer for
the second situation. However, for this case, the disconnect event
comes very late, so the submission couldn't be stopped in time.
The best solution is the driver could get another error code which
indicates the device is disappear for the second situation.  Then,
I don't need to do delayed resubmission.

Best Regards,
Hayes