netdev - Re: pull request: bluetooth 2021-10-01

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211001210832.5902ea53@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 1 Oct 2021 21:08:32 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: pull request: bluetooth 2021-10-01

On Fri, 1 Oct 2021 20:29:54 -0700 Luiz Augusto von Dentz wrote:
> On Fri, Oct 1, 2021 at 8:11 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Fri,  1 Oct 2021 16:08:50 -0700 Luiz Augusto von Dentz wrote:  
> > > bluetooth-next pull request for net-next:
> > >
> > >  - Add support for MediaTek MT7922 and MT7921
> > >  - Enable support for AOSP extention in Qualcomm WCN399x and Realtek
> > >    8822C/8852A.
> > >  - Add initial support for link quality and audio/codec offload.
> > >  - Rework of sockets sendmsg to avoid locking issues.
> > >  - Add vhci suspend/resume emulation.  

> > Commit 0b59e272f932 ("Bluetooth: reorganize functions from hci_sock_sendmsg()")
> >         committer Signed-off-by missing
> >         author email:    penguin-kernel@...ove.SAKURA.ne.jp
> >         committer email: marcel@...tmann.org
> >         Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> >         Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>  
> 
> I suspect those fixed and force pushed since I originally applied them
> given them all have my sign-offs, is this a blocker though?

I'm not an expert on SoB semantics so not sure if it's a deal breaker.
Stephen's checker will definitely notice and send us warnings.
I think it's worth the hassle to rebase and resubmit for 7 bad commits.