netdev - Re: pull request: bluetooth 2021-10-01

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CD773E87-F8E5-47E8-B21A-07EAD6007519@holtmann.org>
Date:   Sat, 2 Oct 2021 11:32:03 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: pull request: bluetooth 2021-10-01

Hi Jakub,

>>>> bluetooth-next pull request for net-next:
>>>> 
>>>> - Add support for MediaTek MT7922 and MT7921
>>>> - Enable support for AOSP extention in Qualcomm WCN399x and Realtek
>>>>   8822C/8852A.
>>>> - Add initial support for link quality and audio/codec offload.
>>>> - Rework of sockets sendmsg to avoid locking issues.
>>>> - Add vhci suspend/resume emulation.  
> 
>>> Commit 0b59e272f932 ("Bluetooth: reorganize functions from hci_sock_sendmsg()")
>>>        committer Signed-off-by missing
>>>        author email:    penguin-kernel@...ove.SAKURA.ne.jp
>>>        committer email: marcel@...tmann.org
>>>        Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
>>>        Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>  
>> 
>> I suspect those fixed and force pushed since I originally applied them
>> given them all have my sign-offs, is this a blocker though?
> 
> I'm not an expert on SoB semantics so not sure if it's a deal breaker.
> Stephen's checker will definitely notice and send us warnings.
> I think it's worth the hassle to rebase and resubmit for 7 bad commits.

at some point, I had to fix one commit via git rebase —interactive. Looks like it
then made me committer for all commits. Originally Luiz applied all these patches
and my Signed-off-by should be in it.

I can fix this for sure and get the right committer back, I am just curious what
git rebase did here.

Regards

Marcel