netdev - Re: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 2 Oct 2021 18:43:17 +0900
From:   Kuniyuki Iwashima <kuniyu@...zon.co.jp>
To:     <kuba@...nel.org>
CC:     <Rao.Shoaib@...cle.com>, <andrii@...nel.org>, <ast@...nel.org>,
        <cong.wang@...edance.com>, <daniel@...earbox.net>,
        <davem@...emloft.net>, <edumazet@...gle.com>,
        <jbi.octave@...il.com>, <jiang.wang@...edance.com>,
        <john.fastabend@...il.com>, <kafai@...com>, <kpsingh@...nel.org>,
        <kuniyu@...zon.co.jp>, <songliubraving@...com>,
        <viro@...iv.linux.org.uk>, <yhs@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop()

Date:   Fri, 1 Oct 2021 18:04:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
> On Sat,  2 Oct 2021 00:49:37 +0100 Jules Irenge wrote:
> > Sparse reports a warning at bpf_iter_unix_seq_stop()
> > The root cause is a missing annotation at bpf_iter_unix_seq_stop()
> > 
> > Add the missing __releases(unix_table_lock) annotation
> > 
> > Signed-off-by: Jules Irenge <jbi.octave@...il.com>

Acked-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>

I completely missed that...
Thanks!


> > ---
> >  net/unix/af_unix.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> > index efac5989edb5..9838d4d855e0 100644
> > --- a/net/unix/af_unix.c
> > +++ b/net/unix/af_unix.c
> > @@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v)
> >  }
> >  
> >  static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v)
> > +	__releases(unix_table_lock)
> >  {
> >  	struct bpf_iter_meta meta;
> >  	struct bpf_prog *prog;
> 
> You need to CC bpf@...r... and netdev@...r...
> 
> You can drop the CC for linux-kernel@, approximately nobody reads that.

Added bpf and netdev, and dropped linux-kernel.

Thank you.