netdev - Re: [PATCH net-next 3/4 v4] net: dsa: rtl8366rb: Support fast aging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaZ7tUwv8OjBaHJ-Da9mBrBy5AuK+p3m4J=hZyyKHTx4w@mail.gmail.com>
Date:   Tue, 5 Oct 2021 00:41:32 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>,
        DENG Qingfang <dqfext@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>
Subject: Re: [PATCH net-next 3/4 v4] net: dsa: rtl8366rb: Support fast aging

On Wed, Sep 29, 2021 at 11:45 PM Vladimir Oltean <olteanv@...il.com> wrote:
> On Wed, Sep 29, 2021 at 11:03:48PM +0200, Linus Walleij wrote:

> > +     /* This will age out any learned L2 entries */
> > +     regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL,
> > +                        BIT(port), BIT(port));
>
> Is there any delay that needs to be added between these two operations?
>
> > +     /* Restore the normal state of things */
> > +     regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL,
> > +                        BIT(port), 0);

Absolutely no idea. The API from the vendor essentially just set/clear
this bit with no comments on use.

Yours,
Linus Walleij