netdev - Re: [PATCH iproute2-next 09/12] ip: nexthop: add cache helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c036dc79-0d78-df8b-343b-fa9a913bd5cf@gmail.com>
Date:   Sun, 3 Oct 2021 18:33:47 -0600
From:   David Ahern <dsahern@...il.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc:     roopa@...dia.com, donaldsharp72@...il.com, idosch@...sch.org,
        Nikolay Aleksandrov <nikolay@...dia.com>
Subject: Re: [PATCH iproute2-next 09/12] ip: nexthop: add cache helpers

On 9/30/21 5:38 AM, Nikolay Aleksandrov wrote:
> +static struct nh_entry *ipnh_cache_add(__u32 nh_id)
> +{
> +	struct rtnl_handle cache_rth = { .fd = -1 };
> +	struct nlmsghdr *answer = NULL;
> +	struct nh_entry *nhe = NULL;
> +
> +	if (rtnl_open(&cache_rth, 0) < 0)

Set applied to iproute-next; wondering if this can be cached - avoid the
open on every nexthop.