Date:   Mon, 04 Oct 2021 00:40:08 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Nikolay Aleksandrov <razor@...ckwall.org>
Cc:     netdev@...r.kernel.org, roopa@...dia.com, donaldsharp72@...il.com,
        dsahern@...il.com, idosch@...sch.org, nikolay@...dia.com
Subject: Re: [PATCH iproute2-next 00/12] ip: nexthop: cache nexthops and print
 routes' nh info

Hello:

This series was applied to iproute2/iproute2-next.git (refs/heads/main):

On Thu, 30 Sep 2021 14:38:32 +0300 you wrote:
> From: Nikolay Aleksandrov <nikolay@...dia.com>
> 
> Hi,
> This set tries to help with an old ask that we've had for some time
> which is to print nexthop information while monitoring or dumping routes.
> The core problem is that people cannot follow nexthop changes while
> monitoring route changes, by the time they check the nexthop it could be
> deleted or updated to something else. In order to help them out I've
> added a nexthop cache which is populated (only used if -d / show_details
> is specified) while decoding routes and kept up to date while monitoring.
> The nexthop information is printed on its own line starting with the
> "nh_info" attribute and its embedded inside it if printing JSON. To
> cache the nexthop entries I parse them into structures, in order to
> reuse most of the code the print helpers have been altered so they rely
> on prepared structures. Nexthops are now always parsed into a structure,
> even if they won't be cached, that structure is later used to print the
> nexthop and destroyed if not going to be cached. New nexthops (not found
> in the cache) are retrieved from the kernel using a private netlink
> socket so they don't disrupt an ongoing dump, similar to how interfaces
> are retrieved and cached.
> 
> [...]

Here is the summary with links:
  - [iproute2-next,01/12] ip: print_rta_if takes ifindex as device argument instead of attribute
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=f72789965eff
  - [iproute2-next,02/12] ip: export print_rta_gateway version which outputs prepared gateway string
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=371e889da771
  - [iproute2-next,03/12] ip: nexthop: add resilient group structure
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=cfb0a8729ea4
  - [iproute2-next,04/12] ip: nexthop: split print_nh_res_group into parse and print parts
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=60a7515b89ff
  - [iproute2-next,05/12] ip: nexthop: add nh entry structure
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=7ec1cee630e3
  - [iproute2-next,06/12] ip: nexthop: parse attributes into nh entry structure before printing
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=945c26db686b
  - [iproute2-next,07/12] ip: nexthop: factor out print_nexthop's nh entry printing
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=a2ca43121501
  - [iproute2-next,08/12] ip: nexthop: factor out ipnh_get_id rtnl talk into a helper
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=53d7c43bd385
  - [iproute2-next,09/12] ip: nexthop: add cache helpers
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=60a970303288
  - [iproute2-next,10/12] ip: nexthop: add a helper which retrieves and prints cached nh entry
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=cb3d18c29e20
  - [iproute2-next,11/12] ip: route: print and cache detailed nexthop information when requested
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=5d5dc549ce7d
  - [iproute2-next,12/12] ip: nexthop: add print_cache_nexthop which prints and manages the nh cache
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=7ca868a7aa26

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Powered by blists - more mailing lists