netdev - Re: [PATCH 1/2 iproute2] configure: support --param=value style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42421564-cc08-3b76-d245-164d9c039ad2@gmail.com>
Date:   Sun, 3 Oct 2021 19:28:30 -0600
From:   David Ahern <dsahern@...il.com>
To:     Andrea Claudi <aclaudi@...hat.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org, bluca@...ian.org
Subject: Re: [PATCH 1/2 iproute2] configure: support --param=value style

On 10/2/21 10:41 AM, Andrea Claudi wrote:
> diff --git a/configure b/configure
> index 7f4f3bd9..f0c81ee1 100755
> --- a/configure
> +++ b/configure
> @@ -504,15 +504,28 @@ else
>  			--include_dir)
>  				INCLUDE=$2
>  				shift 2 ;;
> +			--include_dir=*)
> +				INCLUDE="${1#*=}"
> +				shift ;;
>  			--libbpf_dir)
>  				LIBBPF_DIR="$2"
>  				shift 2 ;;
> +			--libbpf_dir=*)
> +				LIBBPF_DIR="${1#*=}"
> +				shift ;;

We should be able to consolidate these into 1 case like:

			--libbpf_dir|--libbpf_dir=)

and then handle the difference in argument style. e.g.,

			LIBBPF_FORCE="${1#*=}"
			if [ -z "${LIBBPF_FORCE}" ]; then
				LIBBPF_FORCE=$2
				shift
			fi

			....


>  			--libbpf_force)
>  				if [ "$2" != 'on' ] && [ "$2" != 'off' ]; then
>  					usage 1
>  				fi
>  				LIBBPF_FORCE=$2
>  				shift 2 ;;
> +			--libbpf_force=*)
> +				libbpf_f="${1#*=}"
> +				if [ "$libbpf_f" != 'on' ] && [ "$libbpf_f" != 'off' ]; then
> +					usage 1
> +				fi
> +				LIBBPF_FORCE="$libbpf_f"
> +				shift ;;
>  			-h | --help)
>  				usage 0 ;;
>  			"")
>