netdev - Re: [PATCH net-next 1/4] mlx4: replace mlx4_mac_to_u64() with ether_addr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a428a7fd-1c2b-ab8e-b032-f7b8d4b293d9@gmail.com>
Date:   Tue, 5 Oct 2021 12:55:42 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, tariqt@...dia.com, yishaih@...dia.com,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] mlx4: replace mlx4_mac_to_u64() with
 ether_addr_to_u64()



On 10/4/2021 10:14 PM, Jakub Kicinski wrote:
> mlx4_mac_to_u64() predates and opencodes ether_addr_to_u64().
> It doesn't make the argument constant so it'll be problematic
> when dev->dev_addr becomes a const. Convert to the generic helper.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>   drivers/infiniband/hw/mlx4/main.c              |  2 +-
>   drivers/infiniband/hw/mlx4/qp.c                |  2 +-
>   drivers/net/ethernet/mellanox/mlx4/cmd.c       |  2 +-
>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 16 ++++++++--------
>   drivers/net/ethernet/mellanox/mlx4/fw.c        |  2 +-
>   include/linux/mlx4/driver.h                    | 12 ------------
>   6 files changed, 12 insertions(+), 24 deletions(-)
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>