netdev - Re: [PATCH net-next 2/4] mlx4: replace mlx4_u64_to_mac() with u64_to_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b1b45b5-546c-2ce3-a5d9-e8463ba588b3@gmail.com>
Date:   Tue, 5 Oct 2021 12:59:55 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, tariqt@...dia.com, yishaih@...dia.com,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] mlx4: replace mlx4_u64_to_mac() with
 u64_to_ether_addr()



On 10/4/2021 10:14 PM, Jakub Kicinski wrote:
> mlx4_u64_to_mac() predates the common helper but doesn't
> make the argument constant.
> 

Neither does the argument constant.

> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>   drivers/net/ethernet/mellanox/mlx4/cmd.c |  2 +-
>   include/linux/mlx4/driver.h              | 10 ----------
>   2 files changed, 1 insertion(+), 11 deletions(-)
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>