netdev - Re: [PATCH net-next 3/4] mlx4: remove custom dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63e8f75a-7b24-0920-a57e-010ac76f8d69@gmail.com>
Date:   Tue, 5 Oct 2021 13:21:27 +0300
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, tariqt@...dia.com, yishaih@...dia.com,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 3/4] mlx4: remove custom dev_addr clearing



On 10/4/2021 10:14 PM, Jakub Kicinski wrote:
> mlx4_en_u64_to_mac() takes the dev->dev_addr pointer and writes
> to it byte by byte. It also clears the two bytes _after_ ETH_ALEN
> which seems unnecessary. dev->addr_len is set to ETH_ALEN just
> before the call.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>   drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 ++++++--------
>   1 file changed, 6 insertions(+), 8 deletions(-)
> 

Reviewed-by: Tariq Toukan <tariqt@...dia.com>