netdev - Re: [PATCH net-next 1/4 v4] net: dsa: rtl8366rb: Support disabling learning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c399197c-65a2-51da-0efd-e553acd86999@bang-olufsen.dk>
Date:   Tue, 5 Oct 2021 14:45:44 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Re: [PATCH net-next 1/4 v4] net: dsa: rtl8366rb: Support disabling
 learning

On 10/5/21 4:07 PM, Linus Walleij wrote:
> On Tue, Oct 5, 2021 at 9:59 AM Alvin Šipraga <ALSI@...g-olufsen.dk> wrote:
>> On 10/4/21 10:57 PM, Linus Walleij wrote:
> 
>>> BTW: all the patches i have left are extensions to RTL8366RB
>>> specifically so I think it should be fine for you to submit patches
>>> for your switch on top of net-next, maybe we can test this
>>> on you chip too, I suspect it works the same on all Realtek
>>> switches?
>>
>> Generally speaking I don't think that the patches you have sent for 66RB
>> are particularly relevant for the 65MB because the register layout and
>> some chip semantics are totally different.
> 
> I was mainly thinking about the crazy VLAN set-up that didn't use
> port isolation and which is now deleted. But  maybe you were not
> using the rtl8366.c file either? Just realtek-smi.c?

Ah, I was just not using those particularly freaky VLAN functions from 
the rtl8366 library. I still use vlan_{add,del} and the MIB counter 
helpers though, as these seem to be OK. I have been keeping up-to-date 
with your changes to rtl8366.c and tested them locally with my subdriver 
and they are working like a charm. So we should still benefit from some 
level of code reuse.

	Alvin

> 
>> Regarding CPU port learning
>> for the RTL8365MB chip: right now I am playing around with the "third
>> way" Vladimir suggested, by enabling learning selectively only for
>> bridge-layer packets (skb->offload_fwd_mark == true). To begin with I'm
>> not even sure if you have this capability with the RTL8366RB.
> 
> This will be interesting to see!
> 
> Yours,
> Linus Walleij
>