| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20211006230543.3928580-2-joannekoong@fb.com>
Date: Wed, 6 Oct 2021 16:05:41 -0700
From: Joanne Koong <joannekoong@...com>
To: <bpf@...r.kernel.org>
CC: <kafai@...com>, <netdev@...r.kernel.org>, <Kernel-team@...com>,
Joanne Koong <joannekoong@...com>
Subject: [PATCH bpf-next v2 1/3] bpf/xdp: Add bpf_load_hdr_opt support for xdp
This patch enables XDP programs to use the bpf_load_hdr_opt helper
function to load header options.
The upper 16 bits of "flags" is used to denote the offset to the tcp
header. No other flags are, at this time, used by XDP programs.
In the future, more flags can be included to support other types of
header options.
Much of the logic for loading header options can be shared between
sockops and xdp programs. In net/core/filter.c, this common shared
logic is refactored into a separate function both sockops and xdp
use.
Signed-off-by: Joanne Koong <joannekoong@...com>
---
include/uapi/linux/bpf.h | 26 ++++++----
net/core/filter.c | 88 ++++++++++++++++++++++++++--------
tools/include/uapi/linux/bpf.h | 26 ++++++----
3 files changed, 103 insertions(+), 37 deletions(-)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index 6fc59d61937a..2a90e9e5088f 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -4272,21 +4272,28 @@ union bpf_attr {
* A non-negative value equal to or less than *size* on success,
* or a negative error in case of failure.
*
- * long bpf_load_hdr_opt(struct bpf_sock_ops *skops, void *searchby_res, u32 len, u64 flags)
+ * long bpf_load_hdr_opt(void *ctx, void *searchby_res, u32 len, u64 flags)
* Description
- * Load header option. Support reading a particular TCP header
- * option for bpf program (**BPF_PROG_TYPE_SOCK_OPS**).
+ * Load header option. Support reading a particular TCP header
+ * option for bpf programs (**BPF_PROG_TYPE_SOCK_OPS** and
+ * **BPF_PROG_TYPE_XDP**).
*
- * If *flags* is 0, it will search the option from the
- * *skops*\ **->skb_data**. The comment in **struct bpf_sock_ops**
- * has details on what skb_data contains under different
- * *skops*\ **->op**.
+ * *ctx* is either **struct bpf_sock_ops** for SOCK_OPS programs or
+ * **struct xdp_md** for XDP programs.
+ *
+ * For SOCK_OPS programs, if *flags* is 0, it will search the option
+ * from the *skops*\ **->skb_data**. The comment in
+ * **struct bpf_sock_ops** has details on what skb_data contains
+ * under different *skops*\ **->op**.
+ *
+ * For XDP programs, the upper 16 bits of **flags** should contain
+ * the offset to the tcp header.
*
* The first byte of the *searchby_res* specifies the
* kind that it wants to search.
*
* If the searching kind is an experimental kind
- * (i.e. 253 or 254 according to RFC6994). It also
+ * (i.e. 253 or 254 according to RFC6994), it also
* needs to specify the "magic" which is either
* 2 bytes or 4 bytes. It then also needs to
* specify the size of the magic by using
@@ -4309,7 +4316,7 @@ union bpf_attr {
* *len* must be at least 2 bytes which is the minimal size
* of a header option.
*
- * Supported flags:
+ * Supported flags for **SOCK_OPS** programs:
*
* * **BPF_LOAD_HDR_OPT_TCP_SYN** to search from the
* saved_syn packet or the just-received syn packet.
@@ -6018,6 +6025,7 @@ enum {
enum {
BPF_LOAD_HDR_OPT_TCP_SYN = (1ULL << 0),
+ BPF_LOAD_HDR_OPT_TCP_OFFSET_SHIFT = 48,
};
/* args[0] value during BPF_SOCK_OPS_HDR_OPT_LEN_CB and
diff --git a/net/core/filter.c b/net/core/filter.c
index 4bace37a6a44..400ff2ec8ce5 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -6904,19 +6904,19 @@ static const u8 *bpf_search_tcp_opt(const u8 *op, const u8 *opend,
return ERR_PTR(-ENOMSG);
}
-BPF_CALL_4(bpf_sock_ops_load_hdr_opt, struct bpf_sock_ops_kern *, bpf_sock,
- void *, search_res, u32, len, u64, flags)
+static int bpf_load_hdr_opt(const u8 *op, const u8 *opend, void *search_res,
+ u32 len)
{
- bool eol, load_syn = flags & BPF_LOAD_HDR_OPT_TCP_SYN;
- const u8 *op, *opend, *magic, *search = search_res;
u8 search_kind, search_len, copy_len, magic_len;
+ const u8 *magic, *search = search_res;
+ bool eol;
int ret;
/* 2 byte is the minimal option len except TCPOPT_NOP and
* TCPOPT_EOL which are useless for the bpf prog to learn
* and this helper disallow loading them also.
*/
- if (len < 2 || flags & ~BPF_LOAD_HDR_OPT_TCP_SYN)
+ if (len < 2)
return -EINVAL;
search_kind = search[0];
@@ -6939,6 +6939,67 @@ BPF_CALL_4(bpf_sock_ops_load_hdr_opt, struct bpf_sock_ops_kern *, bpf_sock,
magic_len = 0;
}
+ op = bpf_search_tcp_opt(op, opend, search_kind, magic, magic_len,
+ &eol);
+
+ if (IS_ERR(op))
+ return PTR_ERR(op);
+
+ copy_len = op[1];
+ ret = copy_len;
+ if (copy_len > len) {
+ ret = -ENOSPC;
+ copy_len = len;
+ }
+
+ memcpy(search_res, op, copy_len);
+ return ret;
+}
+
+BPF_CALL_4(bpf_xdp_load_hdr_opt, struct xdp_buff *, xdp,
+ void *, search_res, u32, len, u64, flags)
+{
+ const void *op, *opend;
+ struct tcphdr *th;
+
+ /* The upper 16 bits of flags contain the offset to the tcp header.
+ * No other bits should be set.
+ */
+ if (flags & ((1ULL << BPF_LOAD_HDR_OPT_TCP_OFFSET_SHIFT) - 1))
+ return -EINVAL;
+
+ th = xdp->data + (flags >> BPF_LOAD_HDR_OPT_TCP_OFFSET_SHIFT);
+ op = (void *)th + sizeof(struct tcphdr);
+ if (unlikely(op > xdp->data_end))
+ return -EINVAL;
+
+ opend = (void *)th + th->doff * 4;
+ if (unlikely(opend > xdp->data_end))
+ return -EINVAL;
+
+ return bpf_load_hdr_opt(op, opend, search_res, len);
+}
+
+static const struct bpf_func_proto bpf_xdp_load_hdr_opt_proto = {
+ .func = bpf_xdp_load_hdr_opt,
+ .gpl_only = false,
+ .ret_type = RET_INTEGER,
+ .arg1_type = ARG_PTR_TO_CTX,
+ .arg2_type = ARG_PTR_TO_MEM,
+ .arg3_type = ARG_CONST_SIZE,
+ .arg4_type = ARG_ANYTHING,
+};
+
+BPF_CALL_4(bpf_sock_ops_load_hdr_opt, struct bpf_sock_ops_kern *, bpf_sock,
+ void *, search_res, u32, len, u64, flags)
+{
+ bool load_syn = flags & BPF_LOAD_HDR_OPT_TCP_SYN;
+ const u8 *op, *opend;
+ int ret;
+
+ if (flags & ~BPF_LOAD_HDR_OPT_TCP_SYN)
+ return -EINVAL;
+
if (load_syn) {
ret = bpf_sock_ops_get_syn(bpf_sock, TCP_BPF_SYN, &op);
if (ret < 0)
@@ -6956,20 +7017,7 @@ BPF_CALL_4(bpf_sock_ops_load_hdr_opt, struct bpf_sock_ops_kern *, bpf_sock,
op = bpf_sock->skb->data + sizeof(struct tcphdr);
}
- op = bpf_search_tcp_opt(op, opend, search_kind, magic, magic_len,
- &eol);
- if (IS_ERR(op))
- return PTR_ERR(op);
-
- copy_len = op[1];
- ret = copy_len;
- if (copy_len > len) {
- ret = -ENOSPC;
- copy_len = len;
- }
-
- memcpy(search_res, op, copy_len);
- return ret;
+ return bpf_load_hdr_opt(op, opend, search_res, len);
}
static const struct bpf_func_proto bpf_sock_ops_load_hdr_opt_proto = {
@@ -7488,6 +7536,8 @@ xdp_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
return &bpf_tcp_check_syncookie_proto;
case BPF_FUNC_tcp_gen_syncookie:
return &bpf_tcp_gen_syncookie_proto;
+ case BPF_FUNC_load_hdr_opt:
+ return &bpf_xdp_load_hdr_opt_proto;
#endif
default:
return bpf_sk_base_func_proto(func_id);
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 6fc59d61937a..2a90e9e5088f 100644
--- a/tools/include/uapi/linux/bpf.h
+++ b/tools/include/uapi/linux/bpf.h
@@ -4272,21 +4272,28 @@ union bpf_attr {
* A non-negative value equal to or less than *size* on success,
* or a negative error in case of failure.
*
- * long bpf_load_hdr_opt(struct bpf_sock_ops *skops, void *searchby_res, u32 len, u64 flags)
+ * long bpf_load_hdr_opt(void *ctx, void *searchby_res, u32 len, u64 flags)
* Description
- * Load header option. Support reading a particular TCP header
- * option for bpf program (**BPF_PROG_TYPE_SOCK_OPS**).
+ * Load header option. Support reading a particular TCP header
+ * option for bpf programs (**BPF_PROG_TYPE_SOCK_OPS** and
+ * **BPF_PROG_TYPE_XDP**).
*
- * If *flags* is 0, it will search the option from the
- * *skops*\ **->skb_data**. The comment in **struct bpf_sock_ops**
- * has details on what skb_data contains under different
- * *skops*\ **->op**.
+ * *ctx* is either **struct bpf_sock_ops** for SOCK_OPS programs or
+ * **struct xdp_md** for XDP programs.
+ *
+ * For SOCK_OPS programs, if *flags* is 0, it will search the option
+ * from the *skops*\ **->skb_data**. The comment in
+ * **struct bpf_sock_ops** has details on what skb_data contains
+ * under different *skops*\ **->op**.
+ *
+ * For XDP programs, the upper 16 bits of **flags** should contain
+ * the offset to the tcp header.
*
* The first byte of the *searchby_res* specifies the
* kind that it wants to search.
*
* If the searching kind is an experimental kind
- * (i.e. 253 or 254 according to RFC6994). It also
+ * (i.e. 253 or 254 according to RFC6994), it also
* needs to specify the "magic" which is either
* 2 bytes or 4 bytes. It then also needs to
* specify the size of the magic by using
@@ -4309,7 +4316,7 @@ union bpf_attr {
* *len* must be at least 2 bytes which is the minimal size
* of a header option.
*
- * Supported flags:
+ * Supported flags for **SOCK_OPS** programs:
*
* * **BPF_LOAD_HDR_OPT_TCP_SYN** to search from the
* saved_syn packet or the just-received syn packet.
@@ -6018,6 +6025,7 @@ enum {
enum {
BPF_LOAD_HDR_OPT_TCP_SYN = (1ULL << 0),
+ BPF_LOAD_HDR_OPT_TCP_OFFSET_SHIFT = 48,
};
/* args[0] value during BPF_SOCK_OPS_HDR_OPT_LEN_CB and
--
2.30.2
Powered by blists - more mailing lists