netdev - Re: [PATCH net-next v4] net: ipvs: add sysctl_run_estimation to support disable estimation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YV80HOzv+2oV4ppf@salvia>
Date:   Thu, 7 Oct 2021 19:53:32 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Simon Horman <horms@...ge.net.au>
Cc:     Julian Anastasov <ja@....bg>, Dust Li <dust.li@...ux.alibaba.com>,
        Wensong Zhang <wensong@...ux-vs.org>,
        lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org,
        netdev@...r.kernel.org, yunhong-cgl jiang <xintian1976@...il.com>
Subject: Re: [PATCH net-next v4] net: ipvs: add sysctl_run_estimation to
 support disable estimation

On Sat, Oct 02, 2021 at 10:59:29AM +0200, Simon Horman wrote:
> On Sat, Aug 21, 2021 at 11:41:50AM +0300, Julian Anastasov wrote:
> > 
> > 	Hello,
> > 
> > On Fri, 20 Aug 2021, Dust Li wrote:
> > 
> > > estimation_timer will iterate the est_list to do estimation
> > > for each ipvs stats. When there are lots of services, the
> > > list can be very large.
> > > We found that estimation_timer() run for more then 200ms on a
> > > machine with 104 CPU and 50K services.
> > > 
> > > yunhong-cgl jiang report the same phenomenon before:
> > > https://www.spinics.net/lists/lvs-devel/msg05426.html
> > > 
> > > In some cases(for example a large K8S cluster with many ipvs services),
> > > ipvs estimation may not be needed. So adding a sysctl blob to allow
> > > users to disable this completely.
> > > 
> > > Default is: 1 (enable)
> > > 
> > > Cc: yunhong-cgl jiang <xintian1976@...il.com>
> > > Signed-off-by: Dust Li <dust.li@...ux.alibaba.com>
> > 
> > 	Looks good to me, thanks!
> > 
> > Acked-by: Julian Anastasov <ja@....bg>
> 
> Likwewise, thanks. And sorry for the delay.
> 
> Acked-by: Simon Horman <horms@...ge.net.au>
> 
> Pablo, could you consider picking this up?

Applied, thanks.