netdev - Re: [PATCH v2 2/2] vsock: Enable y2038 safe timeval for timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a6jkbte4.fsf@suse.de>
Date:   Thu, 07 Oct 2021 18:14:39 +0100
From:   Richard Palethorpe <rpalethorpe@...e.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Stefano Garzarella <sgarzare@...hat.com>,
        Andra Paraschiv <andraprs@...zon.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Arseny Krasnov <arseny.krasnov@...persky.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Richard Palethorpe <rpalethorpe@...hiejp.com>
Subject: Re: [PATCH v2 2/2] vsock: Enable y2038 safe timeval for timeout

Hello Jakub,

Jakub Kicinski <kuba@...nel.org> writes:

> On Thu,  7 Oct 2021 13:31:47 +0100 Richard Palethorpe wrote:
>> Reuse the timeval compat code from core/sock to handle 32-bit and
>> 64-bit timeval structures. Also introduce a new socket option define
>> to allow using y2038 safe timeval under 32-bit.
>> 
>> The existing behavior of sock_set_timeout and vsock's timeout setter
>> differ when the time value is out of bounds. vsocks current behavior
>> is retained at the expense of not being able to share the full
>> implementation.
>> 
>> This allows the LTP test vsock01 to pass under 32-bit compat mode.
>> 
>> Fixes: fe0c72f3db11 ("socket: move compat timeout handling into sock.c")
>> Signed-off-by: Richard Palethorpe <rpalethorpe@...e.com>
>> Cc: Richard Palethorpe <rpalethorpe@...hiejp.com>
>
> This breaks 32bit x86 build:
>
> ERROR: modpost: "__divdi3" [net/vmw_vsock/vsock.ko] undefined!
>
> If the 64 bit division is intention you need to use an appropriate
> helper.

Ah, sorry, that's why sock.c casts usecs to unsigned long. I will do
some more testing a reroll.

-- 
Thank you,
Richard.