netdev - Re: [PATCH net-next v2 1/2] net: enetc: declare NETIF_F_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211007204134.y5ppnce64top4nm4@skbuf>
Date:   Thu, 7 Oct 2021 20:41:35 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH net-next v2 1/2] net: enetc: declare NETIF_F_HW_CSUM and
 do it in software

On Thu, Oct 07, 2021 at 06:30:42PM +0300, Ioana Ciornei wrote:
> This is just a preparation patch for software TSO in the enetc driver.
> Unfortunately, ENETC does not support Tx checksum offload which would
> normally render TSO, even software, impossible.
> 
> Declare NETIF_F_HW_CSUM as part of the feature set and do it at driver
> level using skb_csum_hwoffload_help() so that we can move forward and

The comment is still referencing the other function you were calling in v1.
Anyway, not a big deal, in the end everything ends up in skb_checksum_help().

> also add support for TSO in the next patch.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>