netdev - Re: [PATCH net-next v2 2/2] net: enetc: add support for software TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211007221039.x5gyjcjqc7xl72mt@skbuf>
Date:   Thu, 7 Oct 2021 22:10:40 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Ioana Ciornei <ioana.ciornei@....com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>
Subject: Re: [PATCH net-next v2 2/2] net: enetc: add support for software TSO

On Thu, Oct 07, 2021 at 06:30:43PM +0300, Ioana Ciornei wrote:
> This patch adds support for driver level TSO in the enetc driver using
> the TSO API.
> 
> Beside using the usual tso_build_hdr(), tso_build_data() this specific
> implementation also has to compute the checksum, both IP and L4, for
> each resulted segment. This is because the ENETC controller does not
> support Tx checksum offload which is needed in order to take advantage
> of TSO.
> 
> With the workaround for the ENETC MDIO erratum in place the Tx path of
> the driver is forced to lock/unlock for each skb sent. This is why, even
> though we are computing the checksum by hand we see the following
> improvement in TCP termination on the LS1028A SoC, on a single A72 core
> running at 1.3GHz:
> 
> before: 1.63 Gbits/sec
> after:  2.34 Gbits/sec
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>