netdev - Re: [PATCH] ethernet: Remove redundant 'flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Oct 2021 13:03:39 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     thomas.lendacky@....com, davem@...emloft.net, kuba@...nel.org,
        rmody@...vell.com, skalluru@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, dchickles@...vell.com,
        sburla@...vell.com, fmanlunas@...vell.com,
        ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com,
        somnath.kotur@...adcom.com, sgoutham@...vell.com,
        lcherian@...vell.com, gakula@...vell.com, jerinj@...vell.com,
        hkelam@...vell.com, sbhatta@...vell.com, tariqt@...dia.com,
        saeedm@...dia.com, aelior@...vell.com,
        GR-everest-linux-l2@...vell.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ethernet: Remove redundant 'flush_workqueue()' calls

On Sun, Oct 10, 2021 at 09:01:32AM +0200, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> @@
> expression E;
> @@
> - 	flush_workqueue(E);
> 	destroy_workqueue(E);
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c                 | 2 --
>  drivers/net/ethernet/brocade/bna/bnad.c                  | 1 -
>  drivers/net/ethernet/cavium/liquidio/lio_core.c          | 1 -
>  drivers/net/ethernet/emulex/benet/be_main.c              | 1 -
>  drivers/net/ethernet/marvell/octeontx2/af/cgx.c          | 1 -
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.c          | 2 --
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c      | 1 -
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c     | 1 -
>  drivers/net/ethernet/mellanox/mlx4/cmd.c                 | 2 --
>  drivers/net/ethernet/mellanox/mlx4/en_main.c             | 1 -
>  drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 1 -
>  drivers/net/ethernet/qlogic/qed/qed_sriov.c              | 1 -
>  12 files changed, 15 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com> #mlx*