netdev - Re: [PATCH v2 1/2] net: amd-xgbe: Toggle PLL settings during rate change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211012113204.66daca5a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 12 Oct 2021 11:32:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Raju.Rangoju@....com, Sudheesh Mavila <sudheesh.mavila@....com>
Subject: Re: [PATCH v2 1/2] net: amd-xgbe: Toggle PLL settings during rate
 change

On Tue, 12 Oct 2021 13:13:21 -0500 Tom Lendacky wrote:
> On 10/12/21 1:04 PM, Shyam Sundar S K wrote:
> > For each rate change command submission, the FW has to do phy
> > power off sequence internally. For this to happen correctly, the
> > PLL re-initialization control setting has to be turned off before
> > sending mailbox commands and re-enabled once the command submission
> > is complete.
> > 
> > Co-developed-by: Sudheesh Mavila <sudheesh.mavila@....com>
> > Signed-off-by: Sudheesh Mavila <sudheesh.mavila@....com>
> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>  
> 
> With the minor change below...

For both patches - any more info on the impact?

Will the link not come up? Driver lock up? ..?

It's unclear whether this is a fix for an issue which was always there,
new FW/HW/platform.

Please include information which will allow us to answer those
questions in the commit messages or cover letter for the series.

If it's a fix it will need Fixes tags (seems likely, even if it's a new
FW that surfaced the issue we probably still want the change to go to
stable.)

Thanks!