netdev - Re: [PATCH v2 2/2] net: amd-xgbe: Enable RRC when auto-negotiation is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b803d76-8579-b567-da39-3cbd01c7c74d@amd.com>
Date:   Tue, 12 Oct 2021 13:14:03 -0500
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Raju.Rangoju@....com,
        Sudheesh Mavila <sudheesh.mavila@....com>
Subject: Re: [PATCH v2 2/2] net: amd-xgbe: Enable RRC when auto-negotiation is
 enabled

On 10/12/21 1:04 PM, Shyam Sundar S K wrote:
> Receiver Reset Cycle (RRC) is only required when the
> auto-negotiation is enabled.
> 
> Co-developed-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Sudheesh Mavila <sudheesh.mavila@....com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>

Acked-by: Tom Lendacky <thomas.lendacky@....com>

> ---
> v2: no change
> 
>   drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> index 4465af9b72cf..1a11407e277c 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c
> @@ -2642,7 +2642,9 @@ static int xgbe_phy_link_status(struct xgbe_prv_data *pdata, int *an_restart)
>   	/* No link, attempt a receiver reset cycle */
>   	if (phy_data->rrc_count++ > XGBE_RRC_FREQUENCY) {
>   		phy_data->rrc_count = 0;
> -		xgbe_phy_rrc(pdata);
> +		/* RRC is required only if auto-negotiation is enabled */
> +		if (pdata->phy.autoneg == AUTONEG_ENABLE)
> +			xgbe_phy_rrc(pdata);
>   	}
>   
>   	return 0;
>