netdev - RE: [PATCH net-next 2/2] net: phy: dp83867: add generic PHY loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB27802C56B1012ED7A575E530CAB79@DM6PR11MB2780.namprd11.prod.outlook.com>
Date:   Wed, 13 Oct 2021 06:18:49 +0000
From:   "Ong, Boon Leong" <boon.leong.ong@...el.com>
To:     Wong Vee Khee <vee.khee.wong@...ux.intel.com>
CC:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 2/2] net: phy: dp83867: add generic PHY loopback

>> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
>> index bb4369b75179..af47c62d6e04 100644
>> --- a/drivers/net/phy/dp83867.c
>> +++ b/drivers/net/phy/dp83867.c
>> @@ -878,6 +878,7 @@ static struct phy_driver dp83867_driver[] = {
>>
>>  		.suspend	= genphy_suspend,
>>  		.resume		= genphy_resume,
>> +		.set_loopback	= genphy_loopback,
>
>Isn't this already handled in phy_loopback() in
>drivers/net/phy/phy_device.c?
>
That is right. Thanks.