netdev - Re: [PATCH v4 net-next 10/10] net: dsa: microchip: add support for vlan operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211014141930.3e5x2wgitsw57v4z@skbuf>
Date:   Thu, 14 Oct 2021 17:19:30 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
Cc:     andrew@...n.ch, netdev@...r.kernel.org, robh+dt@...nel.org,
        UNGLinuxDriver@...rochip.com, Woojung.Huh@...rochip.com,
        hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4 net-next 10/10] net: dsa: microchip: add support for
 vlan operations

On Mon, Oct 11, 2021 at 11:13:36PM +0530, Prasanna Vengateshan wrote:
> > Do you have an explanation for what SW_VLAN_ENABLE does exactly?
> Enabling the VLAN mode and then act as per the VLAN table.
> Do you want me to add this explanation as a comment? or?

Yes, not all switches have the same knobs, it would be good to have a
comment about what you are changing.

> Step (0)
> > ip link add br0 type bridge vlan_filtering 1
> > ip link set lan0 master br0
> > bridge vlan add dev lan0 vid 100 pvid untagged
> Step (1)
> > bridge vlan del dev lan0 vid 100
> Step (2)
> > ip link set br0 type bridge vlan_filtering 0
> > 
> > The expectation is that the switch, being VLAN-unaware as it is currently
> > configured, receives and sends any packet regardless of VLAN ID.
> > If you put an IP on br0 in this state, are you able to ping an outside host?
> 
> I have numbered the commands above.
> Results are,
> Before Step (0). Am able to ping outside.
> After Step (0). Am not able to ping outside because the vlan table is set
> After Step (1). Am not able to ping outside
> After Step (2). Am able to ping outside because of vlan unaware mode.

This sounds okay.