netdev - Re: [PATCH net-next v4 04/15] mctp: Add sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37c35854b5f351dc1d06f17ea63c1009e4d9b944.camel@codeconstruct.com.au>
Date:   Sat, 16 Oct 2021 10:12:58 +0800
From:   Jeremy Kerr <jk@...econstruct.com.au>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     netdev@...r.kernel.org, Matt Johnston <matt@...econstruct.com.au>,
        Andrew Jeffery <andrew@...id.au>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v4 04/15] mctp: Add sockaddr_mctp to uapi

Hi Eugene,

> On Thu, Jul 29, 2021 at 10:20:42AM +0800, Jeremy Kerr wrote:
> >  struct sockaddr_mctp {
> > +       unsigned short int      smctp_family;
> > +       int                     smctp_network;
> 
> struct mctp_skb_cb.net (as well as struct mctp_dev.net) are unsigned,
> is it intentional that this field (along with struct
> mctp_sock.bind_net) differs in signedness?

No, that's not intentional - I'll submit a patch to unify those.

Thanks for the review.

Cheers,


Jeremy