netdev - Re: [PATCH 2/7] mips: uasm: Add workaround for Loongson-2F nop CPU errata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM1=_QQqTSABUQ1WgmBS2mgRzYKB7UA7CHyDLfwnnFnEDL4QBw@mail.gmail.com>
Date:   Mon, 18 Oct 2021 14:17:51 +0200
From:   Johan Almbladh <johan.almbladh@...finetworks.com>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        chenhuacai@...nel.org, jiaxun.yang@...goat.com,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Tony Ambardar <tony.ambardar@...il.com>,
        bpf <bpf@...r.kernel.org>, linux-mips@...r.kernel.org,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/7] mips: uasm: Add workaround for Loongson-2F nop CPU errata

You are right, it should say "at" here instead of "ax". The code uses
the MIPS "at" register. AX is a BPF register, so this is a typo in my
commit message.

Thanks,
Johan





On Mon, Oct 18, 2021 at 2:00 PM Maciej W. Rozycki <macro@...am.me.uk> wrote:
>
> On Tue, 5 Oct 2021, Johan Almbladh wrote:
>
> > This patch implements a workaround for the Loongson-2F nop in generated,
> > code, if the existing option CONFIG_CPU_NOP_WORKAROUND is set. Before,
> > the binutils option -mfix-loongson2f-nop was enabled, but no workaround
> > was done when emitting MIPS code. Now, the nop pseudo instruction is
> > emitted as "or ax,ax,zero" instead of the default "sll zero,zero,0". This
>
>  Confusing typo here, s/ax/at/.
>
>   Maciej