netdev - Re: [Intel-wired-lan] [PATCH 1/1] ice: compact the file ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10c80bab-db74-b567-505c-95d74763248f@molgen.mpg.de>
Date:   Mon, 18 Oct 2021 16:05:57 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Yanjun Zhu <yanjun.zhu@...ux.dev>
Cc:     jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        davem@...emloft.net, kuba@...nel.org,
        intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH 1/1] ice: compact the file ice_nvm.c

Dear Yanjun,


Am 18.10.21 um 16:00 schrieb Yanjun Zhu:

> 在 2021/10/18 21:44, Paul Menzel 写道:

>> Am 18.10.21 um 15:17 schrieb yanjun.zhu@...ux.dev:
>>> From: Zhu Yanjun <yanjun.zhu@...ux.dev>
>>>
>>> The function ice_aq_nvm_update_empr is not used, so remove it.
>>
>> Thank you for the patch. Could you please make the commit message 
>> summary more descriptive? Maybe:
>>
>>> ice: Remove unused `ice_aq_nvm_update_empr()`
>>
>> If you find out, what commit removed the usage, that would be also 
>> good to document, but it’s not that important.
> 
> Thanks for your suggestion.
> 
> IMO, removing the unused function is one method of compact file.
> 
> I agree with you that the commit message summary is not important.

Sorry, you misunderstood me. The commit message summary is my opinion 
very important, as it’s what shown in `git log --oneline`, and in this 
case everybody has to read the full commit message to know what the 
commit actually as *compact* is not conveying this meaning and is ambiguous.

Not as important is finding the commit removing the last user, and 
adding a Fixes tag with it.

> If someone finds more important problem in this commit, I will resend the
> 
> patch and change the commit message summary based on your suggestion.

It’d be great, if you sent an improved version.


Kind regards,

Paul