netdev - Re: [net-next RESEND PATCH 1/2] net: dsa: qca8k: tidy for loop in setup and add cpu port check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211018160614.4b24959c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 18 Oct 2021 16:06:14 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [net-next RESEND PATCH 1/2] net: dsa: qca8k: tidy for loop in
 setup and add cpu port check

On Tue, 19 Oct 2021 00:54:17 +0200 Ansuel Smith wrote:
> > > Tidy and organize qca8k setup function from multiple for loop.
> > > Change for loop in bridge leave/join to scan all port and skip cpu port.
> > > No functional change intended.
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>  
> >
> > There's some confusion in patchwork. I think previous posting got
> > applied, but patch 1 of this series git marked as applied.. while
> > it was patch 2 that corresponds to previous posting..?
> >
> > Please make sure you mark new postings as v2 v3 etc. It's not a problem
> > to post a vN+1 and say "no changes" in the change log, while it may be
> > a problem if patchwork bot gets confused and doesn't mark series as
> > superseded appropriately.
> >
> > I'm dropping the remainder of this series from patchwork, please rebase
> > and resend what's missing in net-next.
> >
> > Thanks!  
> 
> Sorry for the mess. I think I got confused.
> I resent these 2 patch (in one go) as i didn't add the net-next tag
> and i thought they got ignored as the target was wrong.
> I didn't receive any review or ack so i thought it was a good idea to
> resend them in one go with the correct tag.
> Hope it's not a stupid question but can you point me where should
> i check to prevent this kind of error?

You can check in patchwork if your submission was indeed ignored.

All the "active" patches are here:

https://patchwork.kernel.org/project/netdevbpf/list/

You can also look up particular patch by using it's message ID:

https://patchwork.kernel.org/project/netdevbpf/patch/<msg-id>/

E.g.

https://patchwork.kernel.org/project/netdevbpf/patch/20211017145646.56-1-ansuelsmth@gmail.com/

If the patch is in New, Under review or Needs ACK state then there's 
no need to resend.

> So anyway i both send these 2 patch as a dedicated patch with the
> absent tag.

Ah! I see the first posting of both now, looks like patchwork realized
it's a repost of patch 1 so it marked that as superseded.