[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YW5qxB8fovdP0JXh@shredder>
Date: Tue, 19 Oct 2021 09:50:44 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
netdev <netdev@...r.kernel.org>,
Eric Dumazet <edumazet@...gle.com>,
"Ahmed S . Darwish" <a.darwish@...utronix.de>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH net-next 1/2] net: sched: fix logic error in
qdisc_run_begin()
On Mon, Oct 18, 2021 at 05:34:01PM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> For non TCQ_F_NOLOCK qdisc, qdisc_run_begin() tries to set
> __QDISC_STATE_RUNNING and should return true if the bit was not set.
>
> test_and_set_bit() returns old bit value, therefore we need to invert.
>
> Fixes: 29cbcd858283 ("net: sched: Remove Qdisc::running sequence counter")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Ahmed S. Darwish <a.darwish@...utronix.de>
> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Tested-by: Ido Schimmel <idosch@...dia.com>
Thanks!
Powered by blists - more mailing lists