netdev - Re: [PATCH net-next 1/2] net: sched: fix logic error in qdisc_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211019075155.5pn35sebyoxqqesq@linutronix.de>
Date:   Tue, 19 Oct 2021 09:51:55 +0200
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "Ahmed S . Darwish" <a.darwish@...utronix.de>
Subject: Re: [PATCH net-next 1/2] net: sched: fix logic error in
 qdisc_run_begin()

On 2021-10-18 17:34:01 [-0700], Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> For non TCQ_F_NOLOCK qdisc, qdisc_run_begin() tries to set
> __QDISC_STATE_RUNNING and should return true if the bit was not set.
> 
> test_and_set_bit() returns old bit value, therefore we need to invert.
> 
> Fixes: 29cbcd858283 ("net: sched: Remove Qdisc::running sequence counter")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Ahmed S. Darwish <a.darwish@...utronix.de>
> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Acked-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Sebastian