netdev - Re: Sysctl addr_gen_mode does not control tunnel link-local addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211020135018.GA21437@ICIPI.localdomain>
Date:   Wed, 20 Oct 2021 09:50:18 -0400
From:   Stephen Suryaputra <ssuryaextr@...il.com>
To:     Antonio Quartulli <a@...table.cc>
Cc:     netdev@...r.kernel.org
Subject: Re: Sysctl addr_gen_mode does not control tunnel link-local addr

On Wed, Oct 20, 2021 at 02:59:01PM +0200, Antonio Quartulli wrote:

> For sure, supporting IN6_ADDR_GEN_MODE_NONE is a low hanging fruit and
> should be implemented.
> 
Thanks for reaffirming this!

> Other than my nitpick above, I'd suggest applying the same change to the
> GRE code path, as the behavior should be the same.

> Moreover, do you think that addrconf_add_mroute() should not be executed
> in this case? Otherwise you could simply add your new code into
> add_v4_addrs().

Initially I was thinking that why there is a need to call
addrconf_add_mroute() given the link-local addr hasn't been set. On a
second look, yes, the conditional is better be in add_v4_addrs(). It
will take care of GRE as well.

I'll put a formal patch.

Thanks!