netdev - Re: [PATCH] nfc: st95hf: Make spi remove() callback return zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da88faf5-33db-b20d-e019-7cca6779b626@canonical.com>
Date:   Wed, 20 Oct 2021 08:55:51 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     netdev@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] nfc: st95hf: Make spi remove() callback return zero

On 19/10/2021 22:49, Uwe Kleine-König wrote:
> If something goes wrong in the remove callback, returning an error code
> just results in an error message. The device still disappears.
> 
> So don't skip disabling the regulator in st95hf_remove() if resetting
> the controller via spi fails. Also don't return an error code which just
> results in two error messages.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/nfc/st95hf/core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>


Best regards,
Krzysztof