netdev - Re: [PATCH net-next 1/6] ethernet: netsec: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Oct 2021 10:20:34 +0300
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Jaswinder Singh <jaswinder.singh@...aro.org>
Subject: Re: [PATCH net-next 1/6] ethernet: netsec: use eth_hw_addr_set()

Hi Jakub,

On Tue, 19 Oct 2021 at 18:00, Jakub Kicinski <kuba@...nel.org> wrote:
>
> Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
> of VLANs...") introduced a rbtree for faster Ethernet address look
> up. To maintain netdev->dev_addr in this tree we need to make all
> the writes to it got through appropriate helpers.
>
> Read the address into an array on the stack, then call
> eth_hw_addr_set().
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: jaswinder.singh@...aro.org
> CC: ilias.apalodimas@...aro.org
> ---
>  drivers/net/ethernet/socionext/netsec.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index baa9f5d1c549..de7d8bf2c226 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -2037,13 +2037,15 @@ static int netsec_probe(struct platform_device *pdev)
>         if (ret && priv->eeprom_base) {
>                 void __iomem *macp = priv->eeprom_base +
>                                         NETSEC_EEPROM_MAC_ADDRESS;
> -
> -               ndev->dev_addr[0] = readb(macp + 3);
> -               ndev->dev_addr[1] = readb(macp + 2);
> -               ndev->dev_addr[2] = readb(macp + 1);
> -               ndev->dev_addr[3] = readb(macp + 0);
> -               ndev->dev_addr[4] = readb(macp + 7);
> -               ndev->dev_addr[5] = readb(macp + 6);
> +               u8 addr[ETH_ALEN];
> +
> +               addr[0] = readb(macp + 3);
> +               addr[1] = readb(macp + 2);
> +               addr[2] = readb(macp + 1);
> +               addr[3] = readb(macp + 0);
> +               addr[4] = readb(macp + 7);
> +               addr[5] = readb(macp + 6);
> +               eth_hw_addr_set(ndev, addr);
>         }
>
>         if (!is_valid_ether_addr(ndev->dev_addr)) {
> --
> 2.31.1
>

Thanks!

Acked-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>