netdev - Re: [PATCH] rtw89: fix error function parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6170da33.1c69fb81.4050d.c355@mx.google.com>
Date:   Thu, 21 Oct 2021 03:10:41 +0000
From:   CGEL <cgel.zte@...il.com>
To:     Pkshih <pkshih@...ltek.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "lv.ruyi@....com.cn" <lv.ruyi@....com.cn>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] rtw89: fix error function parameter

On Thu, Oct 21, 2021 at 01:34:25AM +0000, Pkshih wrote:
> 
> > -----Original Message-----
> > From: kvalo=codeaurora.org@...codeaurora.org <kvalo=codeaurora.org@...codeaurora.org> On Behalf Of Kalle
> > Valo
> > Sent: Wednesday, October 20, 2021 6:04 PM
> > To: Pkshih <pkshih@...ltek.com>
> > Cc: cgel.zte@...il.com; davem@...emloft.net; kuba@...nel.org; lv.ruyi@....com.cn;
> > linux-wireless@...r.kernel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Zeal Robot
> > <zealci@....com.cn>
> > Subject: Re: [PATCH] rtw89: fix error function parameter
> > 
> > Pkshih <pkshih@...ltek.com> writes:
> > 
> > >> -----Original Message-----
> > >> From: kvalo=codeaurora.org@...codeaurora.org
> > >> <kvalo=codeaurora.org@...codeaurora.org> On Behalf Of Kalle
> > >> Valo
> > >> Sent: Wednesday, October 20, 2021 4:50 PM
> > >> To: cgel.zte@...il.com
> > >> Cc: davem@...emloft.net; kuba@...nel.org; Pkshih
> > >> <pkshih@...ltek.com>; lv.ruyi@....com.cn;
> > >> linux-wireless@...r.kernel.org; netdev@...r.kernel.org;
> > >> linux-kernel@...r.kernel.org; Zeal Robot
> > >> <zealci@....com.cn>
> > >> Subject: Re: [PATCH] rtw89: fix error function parameter
> > >>
> > >> cgel.zte@...il.com wrote:
> > >>
> > >> > From: Lv Ruyi <lv.ruyi@....com.cn>
> > >> >
> > >> > This patch fixes the following Coccinelle warning:
> > >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > >> > WARNING  possible condition with no effect (if == else)
> > >> >
> > >> > Reported-by: Zeal Robot <zealci@....com.cn>
> > >> > Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> > >> > Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
> > >>
> > >> Failed to apply, please rebase on top of wireless-drivers-next.
> > >>
> > >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> > >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> > >> error: Did you hand edit your patch?
> > >> It does not apply to blobs recorded in its index.
> > >> hint: Use 'git am --show-current-patch' to see the failed patch
> > >> Applying: rtw89: fix error function parameter
> > >> Using index info to reconstruct a base tree...
> > >> Patch failed at 0001 rtw89: fix error function parameter
> > >>
> > >> Patch set to Changes Requested.
> > >>
> > >
> > > I think this is because the patch is translated into spaces instead of tabs,
> > > in this and following statements.
> > > "                if (is_2g)"
> > 
> > Ah, I did wonder why it failed as I didn't see any similar patches. We
> > have an item about this in the wiki:
> > 
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
> > 
> 
> I don't know why neither.
> 
> I check the mail header of this patch, the mailer is
> "X-Mailer: git-send-email 2.25.1". It should work properly.
> 
> Lv Ruyi, could you help to check what happens?
> 
> --
> Ping-Ke

Thanks for Ping-Ke's suggestion,you are right.The previous patch
is translated into spaces instead of tabs,and I will submitt a
new correct one.