netdev - Re: [PATCH 1/1] ice: remove the unused function ice_aq_nvm_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3770ad64d2232cbdc19f86bc4e42a16@linux.dev>
Date:   Thu, 21 Oct 2021 02:53:30 +0000
From:   yanjun.zhu@...ux.dev
To:     "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Keller, Jacob E" <jacob.e.keller@...el.com>,
        netdev@...r.kernel.org, davem@...emloft.net,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        intel-wired-lan@...ts.osuosl.org, kuba@...nel.org
Subject: Re: [PATCH 1/1] ice: remove the unused function
 ice_aq_nvm_update_empr

October 21, 2021 2:49 AM, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com> wrote:

> On Tue, 2021-10-19 at 05:17 -0400, yanjun.zhu@...ux.dev wrote:
> 
>> From: Zhu Yanjun <yanjun.zhu@...ux.dev>
>> 
>> The function ice_aq_nvm_update_empr is not used, so remove it.
> 
> Thanks for the patch, but there is another one coming soon that will be
> using this function[1]. I'd prefer to keep this to save us from another
> patch reintroducing it in the near future.

Got it.

Zhu Yanjun

> 
> Thanks,
> Tony
> 
> [1] https://patchwork.ozlabs.org/project/intel-wired-
> lan/patch/20211019215423.3383750-1-jacob.e.keller@...el.com/
> 
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
>> ---
>> drivers/net/ethernet/intel/ice/ice_nvm.c | 16 ----------------
>> drivers/net/ethernet/intel/ice/ice_nvm.h |  1 -
>> 2 files changed, 17 deletions(-)
>> 
>> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c
>> b/drivers/net/ethernet/intel/ice/ice_nvm.c
>> index fee37a5844cf..bad374bd7ab3 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_nvm.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.c
>> @@ -1106,22 +1106,6 @@ enum ice_status ice_nvm_write_activate(struct
>> ice_hw *hw, u8 cmd_flags)
>> return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
>> }
>> 
>> -/**
>> - * ice_aq_nvm_update_empr
>> - * @hw: pointer to the HW struct
>> - *
>> - * Update empr (0x0709). This command allows SW to
>> - * request an EMPR to activate new FW.
>> - */
>> -enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw)
>> -{
>> -       struct ice_aq_desc desc;
>> -
>> -       ice_fill_dflt_direct_cmd_desc(&desc,
>> ice_aqc_opc_nvm_update_empr);
>> -
>> -       return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL);
>> -}
>> -
>> /* ice_nvm_set_pkg_data
>> * @hw: pointer to the HW struct
>> * @del_pkg_data_flag: If is set then the current pkg_data store by
>> FW
>> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.h
>> b/drivers/net/ethernet/intel/ice/ice_nvm.h
>> index c6f05f43d593..925225905491 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_nvm.h
>> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.h
>> @@ -39,7 +39,6 @@ enum ice_status
>> ice_aq_erase_nvm(struct ice_hw *hw, u16 module_typeid, struct
>> ice_sq_cd *cd);
>> enum ice_status ice_nvm_validate_checksum(struct ice_hw *hw);
>> enum ice_status ice_nvm_write_activate(struct ice_hw *hw, u8
>> cmd_flags);
>> -enum ice_status ice_aq_nvm_update_empr(struct ice_hw *hw);
>> enum ice_status
>> ice_nvm_set_pkg_data(struct ice_hw *hw, bool del_pkg_data_flag, u8
>> *data,
>> u16 length, struct ice_sq_cd *cd);