netdev - RE: [PATHC bpf v5 3/3] selftests, bpf: Add one test for sockmap with strparser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6172d93e2a470_82a7f2083@john-XPS-13-9370.notmuch>
Date:   Fri, 22 Oct 2021 08:31:10 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Liu Jian <liujian56@...wei.com>, john.fastabend@...il.com,
        daniel@...earbox.net, jakub@...udflare.com, lmb@...udflare.com,
        davem@...emloft.net, kuba@...nel.org, ast@...nel.org,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        kpsingh@...nel.org, netdev@...r.kernel.org, bpf@...r.kernel.org,
        xiyou.wangcong@...il.com
Cc:     liujian56@...wei.com
Subject: RE: [PATHC bpf v5 3/3] selftests, bpf: Add one test for sockmap with
 strparser

Liu Jian wrote:
> Add the test to check sockmap with strparser is working well.
> 
> Signed-off-by: Liu Jian <liujian56@...wei.com>
> ---
>  tools/testing/selftests/bpf/test_sockmap.c | 33 ++++++++++++++++++++--
>  1 file changed, 30 insertions(+), 3 deletions(-)

Hi Liu,

This is a good test, but we should also add one with a parser returning
a value that is not skb->len. This doesn't cover the case fixed in
patch 1/3 correct? For that we would need to modify the BPF prog
itself as well sockmap_parse_prog.c.

For this patch though,

Acked-by: John Fastabend <john.fastabend@...il.com>

Then one more patch is all we need something to break up the skb from
the parser. We really need the test because its not something we
can easily test otherwise and I don't have any use cases that do this
so wouldn't catch it.

Thanks!
John