netdev - RE: [Patch bpf v4 0/4] sock_map: fix ->poll() and update selftests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6172da1091904_82a7f20833@john-XPS-13-9370.notmuch>
Date:   Fri, 22 Oct 2021 08:34:40 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     bpf@...r.kernel.org, Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>
Subject: RE: [Patch bpf v4 0/4] sock_map: fix ->poll() and update selftests

Cong Wang wrote:
> From: Cong Wang <cong.wang@...edance.com>
> 
> This patchset fixes ->poll() for sockets in sockmap and updates
> selftests accordingly with select(). Please check each patch
> for more details.
> 
> Fixes: c50524ec4e3a ("Merge branch 'sockmap: add sockmap support for unix datagram socket'")
> Fixes: 89d69c5d0fbc ("Merge branch 'sockmap: introduce BPF_SK_SKB_VERDICT and support UDP'")
> Acked-by: John Fastabend <john.fastabend@...il.com>
> 
> ---
> v4: add a comment in udp_poll()
> 
> v3: drop sk_psock_get_checked()
>     reuse tcp_bpf_sock_is_readable()
> 
> v2: rename and reuse ->stream_memory_read()
>     fix a compile error in sk_psock_get_checked()
> 
> Cong Wang (3):
>   net: rename ->stream_memory_read to ->sock_is_readable
>   skmsg: extract and reuse sk_msg_is_readable()
>   net: implement ->sock_is_readable() for UDP and AF_UNIX
> 
> Yucong Sun (1):
>   selftests/bpf: use recv_timeout() instead of retries
> 
>  include/linux/skmsg.h                         |  1 +
>  include/net/sock.h                            |  8 +-
>  include/net/tls.h                             |  2 +-
>  net/core/skmsg.c                              | 14 ++++
>  net/ipv4/tcp.c                                |  5 +-
>  net/ipv4/tcp_bpf.c                            | 15 +---
>  net/ipv4/udp.c                                |  3 +
>  net/ipv4/udp_bpf.c                            |  1 +
>  net/tls/tls_main.c                            |  4 +-
>  net/tls/tls_sw.c                              |  2 +-
>  net/unix/af_unix.c                            |  4 +
>  net/unix/unix_bpf.c                           |  2 +
>  .../selftests/bpf/prog_tests/sockmap_listen.c | 75 +++++--------------
>  13 files changed, 58 insertions(+), 78 deletions(-)
> 
> -- 
> 2.30.2
> 

For the series. Thanks.

Acked-by: John Fastabend <john.fastabend@...il.com>