netdev - RE: [EXT] [PATCH net-next v2 1/2] net: qed_ptp: fix redundant check of rc and against -EINVAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 05:27:49 +0000
From:   Prabhakar Kushwaha <pkushwaha@...vell.com>
To:     Jεan Sacren <sakiwit@...il.com>,
        Ariel Elior <aelior@...vell.com>
CC:     GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] [PATCH net-next v2 1/2] net: qed_ptp: fix redundant check
 of rc and against -EINVAL


> -----Original Message-----
> From: Jεan Sacren <sakiwit@...il.com>
> Sent: Friday, October 22, 2021 9:08 AM
> To: Ariel Elior <aelior@...vell.com>
> Cc: GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>;
> davem@...emloft.net; kuba@...nel.org; netdev@...r.kernel.org
> Subject: [EXT] [PATCH net-next v2 1/2] net: qed_ptp: fix redundant check of rc
> and against -EINVAL
> 
> External Email
> 
> ----------------------------------------------------------------------
> From: Jean Sacren <sakiwit@...il.com>
> 
> We should first check rc alone and then check it against -EINVAL to
> avoid repeating the same operation.
> 
> We should also remove the check of !rc in (!rc && !params.b_granted)
> since it is always true.
> 
> With this change, we could also use constant 0 for return.
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---

Acked-by: Prabhakar Kushwaha <pkushwaha@...vell.com>