netdev - RE: [PATCH net-next v2 2/2] net: qed_dev: fix redundant check of rc and against -EINVAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 Oct 2021 05:28:16 +0000
From:   Prabhakar Kushwaha <pkushwaha@...vell.com>
To:     Jεan Sacren <sakiwit@...il.com>,
        Ariel Elior <aelior@...vell.com>
CC:     GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] net: qed_dev: fix redundant check of rc
 and against -EINVAL

> From: Jean Sacren <sakiwit@...il.com>
> 
> We should first check rc alone and then check it against -EINVAL to
> avoid repeating the same operation multiple times.
> 
> We should also remove the check of !rc in this expression since it is
> always true:
> 
> 	(!rc && !resc_lock_params.b_granted)
> 
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> ---
> v2:
> (1) Fix missing else branch. I'm very sorry.
> (2) Add text for !rc removal in the changelog.
> (3) Put two lines of qed_mcp_resc_unlock() call into one.
>     Thank you, Mr. Horman!
>  drivers/net/ethernet/qlogic/qed/qed_dev.c | 31 +++++++++++++----------

Acked-by: Prabhakar Kushwaha <pkushwaha@...vell.com>