netdev - Re: [PATCH iproute2-next] ip: add AMT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211024164641.3e14e35d@hermes.local>
Date:   Sun, 24 Oct 2021 16:46:41 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Taehee Yoo <ap420073@...il.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip: add AMT support

On Sat, 23 Oct 2021 19:36:11 +0000
Taehee Yoo <ap420073@...il.com> wrote:

> +	if (tb[IFLA_AMT_MODE] && RTA_PAYLOAD(tb[IFLA_AMT_MODE]) < sizeof(__u32))
> +		return;

What is this check here for? Is there a case where kernel returns
data without valid mode?

> +
> +	if (tb[IFLA_AMT_MODE]) {
> +		print_string(PRINT_ANY,
> +			     "mode",
> +			     "%s ",
> +			     modename[rta_getattr_u32(tb[IFLA_AMT_MODE])]);
> +	}