netdev - Re: [PATCH iproute2-next] ip: add AMT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acab97fc-e134-47a5-0385-4dc3754a818e@gmail.com>
Date:   Sun, 24 Oct 2021 17:52:27 -0600
From:   David Ahern <dsahern@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Taehee Yoo <ap420073@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip: add AMT support

On 10/24/21 5:45 PM, Stephen Hemminger wrote:
> On Sat, 23 Oct 2021 19:36:11 +0000
> Taehee Yoo <ap420073@...il.com> wrote:
> 
>> +	while (argc > 0) {
>> +		if (matches(*argv, "mode") == 0) {
> 
> Try and reduce/eliminate use of matches() since it creates

Make that do not use matches. We are not accepting that for any new
command line arguments.

> lots of problems when arguments collides.  For example "m" matches
> mode only because it is compared first (vs "max_tunnels").
>