netdev - Re: [PATCH iproute2-next] ip: add AMT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1775071c-208a-132c-eb3e-637204d9cb02@gmail.com>
Date:   Mon, 25 Oct 2021 23:03:26 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip: add AMT support

Hi David and Stephen,
Thank you so much for the review!

On 10/25/21 8:52 AM, David Ahern wrote:
 > On 10/24/21 5:45 PM, Stephen Hemminger wrote:
 >> On Sat, 23 Oct 2021 19:36:11 +0000
 >> Taehee Yoo <ap420073@...il.com> wrote:
 >>
 >>> +	while (argc > 0) {
 >>> +		if (matches(*argv, "mode") == 0) {
 >>
 >> Try and reduce/eliminate use of matches() since it creates
 >
 > Make that do not use matches. We are not accepting that for any new
 > command line arguments.
 >
 >> lots of problems when arguments collides.  For example "m" matches
 >> mode only because it is compared first (vs "max_tunnels").
 >>
 >

Okay, I will use strccmp() instead of matches() then send the v2 patch
Thanks a lot!

Taehee