netdev - Re: [PATCH iproute2-next] ip: add AMT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f26fd10-4f17-502f-05e4-763f59a57de2@gmail.com>
Date:   Mon, 25 Oct 2021 23:07:54 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     dsahern@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip: add AMT support

Hi Stephen,

On 10/25/21 8:46 AM, Stephen Hemminger wrote:
 > On Sat, 23 Oct 2021 19:36:11 +0000
 > Taehee Yoo <ap420073@...il.com> wrote:
 >
 >> +	if (tb[IFLA_AMT_MODE] && RTA_PAYLOAD(tb[IFLA_AMT_MODE]) < 
sizeof(__u32))
 >> +		return;
 >
 > What is this check here for? Is there a case where kernel returns
 > data without valid mode?
 >

This is an unnecessary check. So I will drop this code at the v2 patch.
Thanks a lot!
Taehee