netdev - Re: [PATCH net-next v5] mctp: Implement extended addressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Oct 2021 16:15:49 +0100 (BST)
From:   David Miller <davem@...emloft.net>
To:     jk@...econstruct.com.au
Cc:     netdev@...r.kernel.org, kuba@...nel.org, matt@...econstruct.com.au,
        esyr@...hat.com
Subject: Re: [PATCH net-next v5] mctp: Implement extended addressing

From: Jeremy Kerr <jk@...econstruct.com.au>
Date: Mon, 25 Oct 2021 11:27:57 +0800

> @@ -152,10 +155,16 @@ struct mctp_sk_key {
>  
>  struct mctp_skb_cb {
>  	unsigned int	magic;
> -	unsigned int	net;
> +	int		net;
> +	int		ifindex; /* extended/direct addressing if set */
> +	unsigned char	halen;
>  	mctp_eid_t	src;
> +	unsigned char	haddr[];
>  };
>  
putting a variably sized type in the skb control blocxk is not a good idea.
Overruns will be silent, nothing in the typing protects you from udsing more space
han exists in skb->cb.

Plrease find another way, thank you.