netdev - Re: ethtool: ring configuration for CAN devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211025114300.15b8814c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 25 Oct 2021 11:43:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Marc Kleine-Budde <mkl@...gutronix.de>,
        linux-can <linux-can@...r.kernel.org>, netdev@...r.kernel.org
Subject: Re: ethtool: ring configuration for CAN devices

On Mon, 25 Oct 2021 14:58:58 +0200 Andrew Lunn wrote:
> > > struct ethtool_kringparam {
> > > 	__u32	cmd;
> > > 	__u32   mode;
> > > 	__u32	rx_max_pending;
> > > 	__u32	rx_mini_max_pending;
> > > 	__u32	rx_jumbo_max_pending;
> > > 	__u32	tx_max_pending;
> > > 	__u32	rx_pending;
> > > 	__u32	rx_mini_pending;
> > > 	__u32	rx_jumbo_pending;
> > > 	__u32	tx_pending;
> > > };

Ah, yes, if we do full field-by-field translation the result is not as
bad as embedding the "base" structure, at the cost of additional
boilerplate code in the core. But frankly potato, potatoe.

> > > and use this structure between the ethtool core and the drivers. This
> > > has already been done at least once to allow extending the
> > > API. Semantic patches are good for making the needed changes to all
> > > the drivers.  
> > 
> > What about the proposed "two new parameters ringparam_ext and extack for
> > .get_ringparam and .set_ringparam to extend more ring params through
> > netlink." by Hao Chen/Guangbin Huang in:
> > 
> > https://lore.kernel.org/all/20211014113943.16231-5-huangguangbin2@huawei.com/
> >
> > I personally like the conversion of the in in-kernel API to struct
> > ethtool_kringparam better than adding ringparam_ext.  
> 
> Ah, i missed that development.

I think it's the fifth version and people are starting to have feedback.
Something is not working :(

> I don't like it.
> 
> You should probably jump into that discussion and explain your
> requirements. Make sure it is heading in a direction you can extend
> for your needs.