netdev - Re: [PATCH V4 mlx5-next 06/13] vfio: Fix VFIO_DEVICE_STATE_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k0hzdbk3.fsf@redhat.com>
Date:   Tue, 26 Oct 2021 17:56:44 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     Yishai Hadas <yishaih@...dia.com>, bhelgaas@...gle.com,
        jgg@...dia.com, saeedm@...dia.com, linux-pci@...r.kernel.org,
        kvm@...r.kernel.org, netdev@...r.kernel.org, kuba@...nel.org,
        leonro@...dia.com, kwankhede@...dia.com, mgurtovoy@...dia.com,
        maorg@...dia.com
Subject: Re: [PATCH V4 mlx5-next 06/13] vfio: Fix
 VFIO_DEVICE_STATE_SET_ERROR macro

On Tue, Oct 26 2021, Alex Williamson <alex.williamson@...hat.com> wrote:

> On Tue, 26 Oct 2021 17:32:19 +0200
> Cornelia Huck <cohuck@...hat.com> wrote:
>
>> On Tue, Oct 26 2021, Yishai Hadas <yishaih@...dia.com> wrote:
>> 
>> > Fixed the non-compiled macro VFIO_DEVICE_STATE_SET_ERROR (i.e. SATE
>> > instead of STATE).
>> >
>> > Fixes: a8a24f3f6e38 ("vfio: UAPI for migration interface for device state")
>> > Signed-off-by: Yishai Hadas <yishaih@...dia.com>
>> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>  
>> 
>> This s-o-b chain looks weird; your s-o-b always needs to be last.
>> 
>> > ---
>> >  include/uapi/linux/vfio.h | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
>> > index ef33ea002b0b..114ffcefe437 100644
>> > --- a/include/uapi/linux/vfio.h
>> > +++ b/include/uapi/linux/vfio.h
>> > @@ -622,7 +622,7 @@ struct vfio_device_migration_info {
>> >  					      VFIO_DEVICE_STATE_RESUMING))
>> >  
>> >  #define VFIO_DEVICE_STATE_SET_ERROR(state) \
>> > -	((state & ~VFIO_DEVICE_STATE_MASK) | VFIO_DEVICE_SATE_SAVING | \
>> > +	((state & ~VFIO_DEVICE_STATE_MASK) | VFIO_DEVICE_STATE_SAVING | \
>> >  					     VFIO_DEVICE_STATE_RESUMING)
>> >  
>> >  	__u32 reserved;  
>> 
>> Change looks fine, although we might consider merging it with the next
>> patch? Anyway,
>
> I had requested it separate a couple revisions ago since it's a fix.
> Thanks,
>
> Alex

Fair enough.