netdev - Re: [PATCH V4 mlx5-next 06/13] vfio: Fix VFIO_DEVICE_STATE_SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXgv29Og1Ds2mMSS@unreal>
Date:   Tue, 26 Oct 2021 19:42:03 +0300
From:   Leon Romanovsky <leonro@...dia.com>
To:     Cornelia Huck <cohuck@...hat.com>
CC:     Yishai Hadas <yishaih@...dia.com>, <alex.williamson@...hat.com>,
        <bhelgaas@...gle.com>, <jgg@...dia.com>, <saeedm@...dia.com>,
        <linux-pci@...r.kernel.org>, <kvm@...r.kernel.org>,
        <netdev@...r.kernel.org>, <kuba@...nel.org>,
        <kwankhede@...dia.com>, <mgurtovoy@...dia.com>, <maorg@...dia.com>
Subject: Re: [PATCH V4 mlx5-next 06/13] vfio: Fix VFIO_DEVICE_STATE_SET_ERROR
 macro

On Tue, Oct 26, 2021 at 06:32:08PM +0200, Cornelia Huck wrote:
> On Tue, Oct 26 2021, Leon Romanovsky <leonro@...dia.com> wrote:
> 
> > On Tue, Oct 26, 2021 at 05:32:19PM +0200, Cornelia Huck wrote:
> >> On Tue, Oct 26 2021, Yishai Hadas <yishaih@...dia.com> wrote:
> >> 
> >> > Fixed the non-compiled macro VFIO_DEVICE_STATE_SET_ERROR (i.e. SATE
> >> > instead of STATE).
> >> >
> >> > Fixes: a8a24f3f6e38 ("vfio: UAPI for migration interface for device state")
> >> > Signed-off-by: Yishai Hadas <yishaih@...dia.com>
> >> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> >> 
> >> This s-o-b chain looks weird; your s-o-b always needs to be last.
> >
> > It is not such clear as it sounds.
> >
> > Yishai is author of this patch and at some point of time, this patch passed
> > through my tree and it will pass again, when we will merge it. This is why
> > my SOB is last and not Yishai's.
> 
> Strictly speaking, the chain should be Yishai->you->Yishai and you'd add
> your s-o-b again when you pick it. Yeah, that looks like overkill; the
> current state just looks weird to me, but I'll shut up now.

We will get checkpatch warning about duplicated signature.

WARNING: Duplicate signature
#11:
Signed-off-by: Leon Romanovsky <leonro@...dia.com>
total: 0 errors, 1 warnings, 86 lines checked

Thanks

>