[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YXgwlsyGtK8qZfHj@unreal>
Date: Tue, 26 Oct 2021 19:45:10 +0300
From: Leon Romanovsky <leonro@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <saeedm@...dia.com>,
<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: remove the recent devlink params
On Tue, Oct 26, 2021 at 08:29:39AM -0700, Jakub Kicinski wrote:
> revert commit 46ae40b94d88 ("net/mlx5: Let user configure io_eq_size param")
> revert commit a6cb08daa3b4 ("net/mlx5: Let user configure event_eq_size param")
> revert commit 554604061979 ("net/mlx5: Let user configure max_macs param")
>
> The EQE parameters are applicable to more drivers, they should
> be configured via standard API, probably ethtool. Example of
> another driver needing something similar:
>
> https://lore.kernel.org/all/1633454136-14679-3-git-send-email-sbhatta@marvell.com/
>
> The last param for "max_macs" is probably fine but the documentation
> is severely lacking. The meaning and implications for changing the
> param need to be stated.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>
> LocalWords: EQE param
Your emacs config sneaked out.
Thanks
Powered by blists - more mailing lists